dotnet / dotnet/linker

[feature/dataflow] Handling of reflection on properties with regard to annotations

Open
#1,061 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
392
Forks
128
Avg merge
2d 10h
Merged PRs (30d)
2

Description

Using the annotations if somebody asks for properties on a type via `DynamicallyAccessedMemberKind.Properties` we would include both getter and setter on each property as that's the only sensible thing to do (getting the property alone is typically not useful, either getter or setter will be called on it later on). On the other hand linker tracks getters and setters separately, and so accessing the getter/setter (via `PropertyInfo.GetMethod` for example) will raise a warning as it can be potentially trimmed. Linker won't be able to figure out that the `PropertyInfo` comes from a type which had all properties included and thus both getter/setter are available.

This basically means that the annotations will help with calls to `Type.GetProperty`, but won't help with calls to `PropertyInfo.GetMethod` - those wills till raise warnings.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.