dotnet / dotnet/jitutils

jit-diff (and maybe more) broken by recent runtime build change from windows_nt to windows

Open
#299 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
160
Forks
69
Avg merge
1h 56m
Merged PRs (30d)
1

Description

Not sure yet how we fix this in a backwards compatible fashion.

```diff
index b44e826..a95e5ce 100755
--- a/src/jit-diff/jit-diff.cs
+++ b/src/jit-diff/jit-diff.cs
@@ -94,7 +94,7 @@ private static string GetBuildOS(string platformMoniker)
switch (platformMoniker)
{
case "Windows":
- return "Windows_NT";
+ return "Windows";
case "Linux":
return "Linux";
case "OSX":
```

cc @dotnet/jit-contrib

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.