dotnet / dotnet/jitutils

jit-diff: improve reconciliation when there are multiple methods with the same name

Open
#119 1 comment 0 reactions 1 assignee Claimed by @briansull View on GitHub
Dominant language
C#
Stars
160
Forks
69
Avg merge
1h 56m
Merged PRs (30d)
1

Description

See dotnet/coreclr#14244 -- the "savings" seen here is misleading:
```
-516 : System.Private.CoreLib.dasm - InterfaceIsCheckWorkaround`1:.cctor() (7 methods)
```
The diff version had only 3 of the 7 copies -- the other 4 instantations were no longer needed because of changes in codegen in other methods.

Reconciliation should have noted that the base version had 4 extra methods instead of making it look like both versions had these 7 methods and they shrank a lot.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.