dotnet / dotnet/fsharp

F# ignores custom modifiers (modreq/modopt)

Open
#5,464 0 comments 0 reactions 0 assignees View on GitHub
Area-Compiler-CodeGen Feature Improvement
Dominant language
F#
Stars
4.3k
Forks
876
Avg merge
4d 11h
Merged PRs (30d)
131

Description

F# is ignoring any custom modifiers from importing IL assemblies:
```fsharp
| ILType.Modified(_,_,ty) ->
// All custom modifiers are ignored
ImportILType env m tinst ty
```
This is violating the Ecma spec. We should probably get a list of C#/VB custom modifiers that have CMOD_REQ, and allow those to go through assuming we handle them properly anyway, and then we throw an error on ones that we don't know about; currently, we do not do this.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.