dotnet / dotnet/fsharp

Nullness issue - Spurious(?) 3261 warning with rec module

Open
#20,211 1 comment 0 reactions 1 assignee Claimed by @T-Gro View on GitHub
Area-Nullness Bug Needs-Triage
Dominant language
F#
Stars
4.3k
Forks
876
Avg merge
4d 22h
Merged PRs (30d)
144

Description

### Issue description

The following module generates a 3261 warning:
```
module rec M

open System.Collections.Generic

[]
type Hole = Hole of string with
member this.Value =
let (Hole value) = this in value

type Substitution = Dictionary
```

If you change the first line to `module M`, there is no warning.

### Choose one or more from the following categories of impact

- [x] Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
- [ ] Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
- [ ] Breaking change related to older `null` constructs in code not using the checknulls switch.
- [ ] Breaking change related to generic code and explicit type constraints (`null`, `not null`).
- [ ] Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
- [ ] C#/F# interop issue related to nullness metadata.
- [ ] Other (none of the categories above apply).

### Operating System

Windows (Default)

### What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

### .NET Runtime/SDK version

.NET 10

### Reproducible code snippet and actual behavior

_No response_

### Possible workarounds

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.