dotnet / dotnet/fsharp

Can't build project referencing self-built FCS and FSharp.Core package

Open
#17,800 4 comments 0 reactions 0 assignees View on GitHub
Area-Infrastructure
Dominant language
F#
Stars
4.3k
Forks
876
Avg merge
4d 22h
Merged PRs (30d)
144

Description

I'm trying to upgrade FCS in the Rider plugin. However, there are issues with building.

Due to https://github.com/dotnet/fsharp/pull/17698 FSharp.Core is no longer referenced as a package, and is referenced as a project instead. We build FCS ourselves but I don't know a way to build FSharp.Core properly, so its assembly strong name matches the one published by Microsoft. Is there something that I miss and it's possible? If not, then we need to find a way to use FSharp.Core package when building FCS.

As a workaround I've tried to use both 8.0.400 and the current preview FSharp.Core versions, but I'm getting an error during build:
```
Error CS0115 :
'FsShim.OpenFileForReadShim(string, FSharpOption, FSharpOption)':
no suitable method found to override
```

It seems there may be some issue in the code generated by F# compiler?
Here's a minimized repro:
[FcsFileSystemShimOverride.zip](https://github.com/user-attachments/files/17150129/FcsFileSystemShimOverride.zip)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.