dotnet / dotnet/fsharp

Exception in VS in `itemKeyStore`

Open
#16,275 0 comments 0 reactions 0 assignees View on GitHub
AI-thinks-windows-only Area-VS-Editor Bug Impact-Low Theme-Telemetry
Dominant language
F#
Stars
4.3k
Forks
876
Avg merge
4d 22h
Merged PRs (30d)
144

Description

We're seeing some crash telemetry from VS coming from `itemKeyStore` probably related to `ccu.IsUnresolvedReference`.
https://github.com/dotnet/fsharp/blob/52d98fe79e3c0fef2a89ea515e458db2b8e09689/src/Compiler/TypedTree/TypedTree.fs#L5559-L5562

We should add some `try with` around it in the extension and report the exception to telemetry.

Also we should add filtering for `TaskCanceledException` to [ReportFault](https://github.com/dotnet/fsharp/blob/52d98fe79e3c0fef2a89ea515e458db2b8e09689/vsintegration/src/FSharp.Editor/Telemetry/TelemetryReporter.fs#L112) so canceled tasks don't spam our telemetry.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.