dotnet / dotnet/fsharp

Telemetry exception in VS

Open
#16,083 1 comment 0 reactions 0 assignees View on GitHub
AI-thinks-windows-only Area-VS Bug Impact-Low Theme-Telemetry
Dominant language
F#
Stars
4.3k
Forks
876
Avg merge
4d 11h
Merged PRs (30d)
131

Description

Saw this in VS, should be investigated. The reason Go To Definition failed is probably something I did wrong, but if it ever fails for whatever reason looks like we might not get the telemetry.

**Repro steps**

Use Go To Definition (F12) which for whatever reason fails.

**Expected behavior**

We send the error to telemetry

**Actual behavior**

We get exception:
```
System.ArgumentException: Event name 'gotodefinition/fault' should have at least 3 parts separated by slash.
Parameter name: eventName

at Microsoft.VisualStudio.Telemetry.DataModelEventNameHelper.ValidateEventName(String eventName)

at Microsoft.VisualStudio.Telemetry.DataModelEventNameHelper.SetProductFeatureEntityName(String eventName, PrefixedNotConcurrent`1 reservedProperties)

at Microsoft.VisualStudio.Telemetry.FaultEvent..ctor(String eventName, String description, FaultSeverity faultSeverity, Exception exceptionObject, Func`2 gatherEventDetails)

at Microsoft.VisualStudio.Telemetry.TelemetrySessionExtensions.PostFault(TelemetrySession telemetrySession, String eventName, String description, FaultSeverity faultSeverity, Exception exceptionObject, Func`2 gatherEventDetails, TelemetryEventCorrelation[] correlatedWith)

at Microsoft.VisualStudio.Telemetry.TelemetrySessionExtensions.PostFault(TelemetrySession telemetrySession, String eventName, String description, FaultSeverity faultSeverity, Exception exceptionObject)

at Microsoft.VisualStudio.FSharp.Editor.Telemetry.TelemetryReporter.ReportFault(String name, FSharpOption`1 severity, FSharpOption`1 e) in D:\code\FS\fsharp\vsintegration\src\FSharp.Editor\Telemetry\TelemetryReporter.fs:line 114

at Microsoft.VisualStudio.FSharp.Editor.FSharpNavigation.TryGoToDefinition(Int32 position, CancellationToken cancellationToken) in D:\code\FS\fsharp\vsintegration\src\FSharp.Editor\Navigation\GoToDefinition.fs:line 743

at Microsoft.VisualStudio.FSharp.Editor.FSharpGoToDefinitionService.Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.IFSharpGoToDefinitionService.TryGoToDefinition(Document document, Int32 position, CancellationToken cancellationToken) in D:\code\FS\fsharp\vsintegration\src\FSharp.Editor\Navigation\GoToDefinitionService.fs:line 33

at Microsoft.CodeAnalysis.ExternalAccess.FSharp.Internal.Editor.FSharpGoToDefinitionService.TryGoToDefinition(Document document, Int32 position, CancellationToken cancellationToken)

at Microsoft.CodeAnalysis.GoToDefinition.GoToDefinitionCommandHandler.ExecuteSynchronously(Document document, IGoToDefinitionService service, IAsyncGoToDefinitionService asyncService, Int32 position, CommandExecutionContext context)

at Microsoft.CodeAnalysis.GoToDefinition.GoToDefinitionCommandHandler.ExecuteCommand(GoToDefinitionCommandArgs args, CommandExecutionContext context)

at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService.<>c__DisplayClass15_1`1.<ExecuteStartingAtIndex>b__0()

at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.CallExtensionPoint(Object errorSource, Action call, Predicate`1 exceptionFilter)
```

**Related information**

The telemetry code is from a recent `main`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.