dotnet / dotnet/fsharp

FS3118 and FS0010 when combined with task CE and function name is too long

Open
#15,432 7 comments 3 reactions 1 assignee Claimed by @edgarfgp View on GitHub
Area-Diagnostics Feature Improvement
Dominant language
F#
Stars
4.3k
Forks
876
Avg merge
4d 11h
Merged PRs (30d)
131

Description

Please accept my apologies if this is a known issue, or not reproducible.

**Repro steps**

Use Visual Studio to create a new .NET 6.0 F# class library. Modify the default `Library.fs` file by giving it this content:

```fsharp
module ClassLibrary1

open System.Threading.Tasks

let f2345 () = task {
return () } :> Task
```

**Expected behavior**

The code compiles.

**Actual behavior**

Compilation fails with two error messages:

> error FS0010: Unexpected symbol ':>' in binding. Expected incomplete structured construct at or before this point
> or other token.
>
> error FS3118: Incomplete value or function definition. If this is in an expression, the body of the expression must
> be indented to the same column as the 'let' keyword.

**Known workarounds**

There are (at least) two workarounds to this problem:

1. Make the function name shorter. With the given example, change the function name to `f234`, and the code compiles. The above code is a minimal repro of an issue I've run into more than once, and while I don't understand the exact relationship, the maximum function name length seems to be somehow related to the last expression in the `task` CE. (Here, it's just `return ()`, but with a longer expression, the name can be longer, too.)
2. Format the code like this:

```fsharp
module ClassLibrary1

open System.Threading.Tasks

let f2345 () =
task {
return () } :> Task
```

This alternative formatting seems to resolve the problem, and I haven't seen any problems with it.

This syntax does, however, introduce an extra line of code, and what is worse, an extra level of indentation, which I'd like to avoid.

**Related information**

If you're wondering about why anyone would want to upcast `Task<'a>` to `Task` this is only a minimal repro. My actual use case is asynchronous integration tests written with xUnit.net. The xUnit.net framework can execute `Task`-valued operations, but not `Task<'a>`-valued operations.

I suspect that the repro syntax may strictly speaking not be valid F# syntax, but usually it works. In any case it's confusing that it compiles when the function name is short, but stops compiling when the name exceeds a threshold.

I've discovered this issue while working with F# in Visual Studio (details below), but it also reproduces with `dotnet build` from the command line. I don't know if it reproduces in Visual Studio Code.

Edition Windows 11 Pro
Version 22H2
Installed on ‎27.‎01.‎2023
OS build 22621.1848
Experience Windows Feature Experience Pack 1000.22642.1000.0

.NET 6

Microsoft Visual Studio Community 2022
Version 17.6.3
VisualStudio.17.Release/17.6.3+33801.468
Microsoft .NET Framework
Version 4.8.09032

Installed Version: Community

Visual C++ 2022 00482-90000-00000-AA879
Microsoft Visual C++ 2022

ASP.NET and Web Tools 17.6.326.62524
ASP.NET and Web Tools

Azure App Service Tools v3.0.0 17.6.326.62524
Azure App Service Tools v3.0.0

Azure Functions and Web Jobs Tools 17.6.326.62524
Azure Functions and Web Jobs Tools

C# Tools 4.6.0-3.23259.8+c3cc1d0ceeab1a65da0217e403851a1e8a30086a
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

CodeMaintainability 2022 1.2
Extension for tracking code maintainability of your methods. Instead of often performing report driven code analysis tools, you can use this extension to view in real-time maintainability score.

Common Azure Tools 1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Microsoft JVM Debugger 1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

NuGet Package Manager 6.6.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

Razor (ASP.NET Core) 17.6.0.2327201+a6a61fdfa748eaa65aab53dab583276e26af4a3e
Provides languages services for ASP.NET Core Razor.

SQL Server Data Tools 17.6.13.0
Microsoft SQL Server Data Tools

Surrounder 1.0.12
Surrounds any selected texts with matching quotation or brace pairs

TypeScript Tools 17.0.20329.2001
TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools 4.6.0-3.23259.8+c3cc1d0ceeab1a65da0217e403851a1e8a30086a
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools 17.6.0-beta.23174.5+0207bea1afae48d9351ac26fb51afc8260de0a97
Microsoft Visual F# Tools

Visual Studio IntelliCode 2.2
AI-assisted development for Visual Studio.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.