dotnet / dotnet/fsharp

`Tracking` - Testin - Re-enable disabled test cases

Open
#10,958 0 comments 0 reactions 0 assignees View on GitHub
Area-Testing good first issue help wanted Impact-Low Tracking
Dominant language
F#
Stars
4.3k
Forks
876
Avg merge
4d 11h
Merged PRs (30d)
131

Description

Various tests are disabled because they were flaky or failing. We should re-enable them

* [ ] Compile to assembly https://github.com/dotnet/fsharp/issues/10932
* [ ] LargeListExprDoesNotStackOverflow https://github.com/dotnet/fsharp/issues/10931
* [ ] This PR disabled some bad tests: https://github.com/dotnet/fsharp/pull/11218. These tests are _not good_ because they ultimately rely on some kind of timing invariant (explicit or implicit) and that invariant doesn't hold on the degraded pools we're running on for CI now. These tests need to be rewritten.
* [ ] high entropy and subsystem version tests disabled by PR https://github.com/dotnet/fsharp/pull/2857.
* [ ] The [CancellationPropagatesToGroupImmediate](https://github.com/Microsoft/visualfsharp/blob/2bcb342c2687a13e586052de9000d44ad86b156a/tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncType.fs#L346) test is flaky and hangs in the master and dev15.7 branches. Test has been disabled to prevent code flow. Also CancellationPropagatesToImmediateTask. Test was added in https://github.com/dotnet/fsharp/pull/2534.
* [ ] The test AsyncModule.SleepContinuations is flaky #4887
* [ ] AwaitWaitHandle.Timeout test is flaky. The test was skipped in commit https://github.com/dotnet/fsharp/commit/e04986479f7dda31b54ef9352b1a3d76c0819e90.

In some cases the failures are actually fixed, but due to how internal vm's for testing are configured they don't succeed internally.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.