dotnet / dotnet/format

Remove hardcoded TFMs and replace powershell script with MSBuild projects

Open
#1,814 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
1.9k
Forks
173
Avg merge
10d 13h
Merged PRs (30d)
1

Description

Two powershell scripts currently hardcode the TFM value:

- https://github.com/dotnet/format/blob/0b968051beac5d7c1a62a52aee7fbbbb47dc1f47/eng/format-verifier.ps1#L76
- https://github.com/dotnet/format/blob/0b968051beac5d7c1a62a52aee7fbbbb47dc1f47/eng/perf.ps1#L48

While that wasn't a problem in the past, with now floating TFM versions defined by Arcade (`$(NetCurrent)`), the goal is to upgrade repositories to the next version of .NET more easily.

Ideally the two scripts would be replaced by simple msbuild projects (using the `Microsoft.Build.NoTargets` SDK) that achieve the exact same result (potentially with even less code). MSBuild has access to the entire repo infrastructure, including the `NetCurrent` proprerty and hence those hardcoded entries would go away.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.