dotnet / dotnet/format

Whitespace formatter flags no-op changes

Open
#1,744 3 comments 2 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
1.9k
Forks
173
Avg merge
10d 13h
Merged PRs (30d)
1

Description

Program.cs
```csharp
namespace A {

public class B {
object a = new();

#if !X
#endif

public void A() {
foo();
}
}
}
```

.editorconfig
```
root = true

[*.cs]
indent_style = tab
csharp_new_line_before_open_brace = none
csharp_new_line_before_else = false
csharp_new_line_before_catch = false
csharp_new_line_before_finally = false
```

If I run a master build of dotnet-format on this file using `whitespace --verify-no-changes`, I get this:

```
Program.cs(4,20): error WHITESPACE: Fix whitespace formatting. Replace 2 characters with '\n\n'. [/home/david/src/golf/tmp/tmp.csproj]
Program.cs(8,1): error WHITESPACE: Fix whitespace formatting. Replace 3 characters with '\n\t\t'. [/home/david/src/golf/tmp/tmp.csproj]
Program.cs(10,3): error WHITESPACE: Fix whitespace formatting. Insert '\t'. [/home/david/src/golf/tmp/tmp.csproj]
```

If I fix the indentation of foo, I get no errors. The extra errors always seem to indicate no changes.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.