dotnet / dotnet/format

Fix package version management to let source-build pass in source-built M.Extensions.* packages

Open
#1,400 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
1.9k
Forks
173
Avg merge
10d 13h
Merged PRs (30d)
1

Description

This property name doesn't match up with any package ID, so it doesn't get overridden like a property named `MicrosoftExtensionsDependencyInjectionVersion` would:

https://github.com/dotnet/format/blob/6c354c25d068c87326f15fd0fa797ef19d0d1b71/Directory.Packages.props#L5

That means these package references will be 5.0.0 even when we're building 6.0 from source:

https://github.com/dotnet/format/blob/6c354c25d068c87326f15fd0fa797ef19d0d1b71/Directory.Packages.props#L28-L30

We're working around it in 6.0.100 with a patch that changes `MicrosoftExtensionsVersion` to `MicrosoftExtensionsDependencyInjectionVersion`, which should be integrated.

* See https://github.com/dotnet/source-build/issues/2558
* 6.0.100 workaround PR: https://github.com/dotnet/installer/pull/12493

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.