dotnet / dotnet/extensions

Microsoft.Extensions.ServiceDiscovery.Dns save SRV target host

Open
#7,473 0 comments 0 reactions 0 assignees View on GitHub
needs-area-label untriaged
Dominant language
C#
Stars
3.2k
Forks
894
Avg merge
1d 12h
Merged PRs (30d)
23

Description

When resolving kubernetes services it would be useful to also resolve the names of the target services, not only the IP.

The DNSresolver already provide them. So storing it in the feature collection could be done.

https://github.com/dotnet/extensions/blob/bab6ce04720483a1d9a0b790b570b989dc4fbe7f/src/Libraries/Microsoft.Extensions.ServiceDiscovery.Dns/DnsSrvServiceEndpointProvider.cs#L39

```
endpoints.Add(CreateEndpoint(new IPEndPoint(address.Address, record.Port))); <-- here store as a Feature
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.