dotnet / dotnet/extensions

Add more tests to Microsoft.Extensions.ServiceDiscovery.Dns and clean up code

Open
#6,872 1 comment 0 reactions 0 assignees View on GitHub
needs-area-label untriaged
Dominant language
C#
Stars
3.2k
Forks
894
Avg merge
1d 12h
Merged PRs (30d)
23

Description

See PR feedback here:

* https://github.com/dotnet/extensions/pull/6868#discussion_r2392616616
* https://github.com/dotnet/extensions/pull/6868#discussion_r2392627021
* https://github.com/dotnet/extensions/pull/6868#discussion_r2392538171

There doesn't appear to be test coverage for the first 2 methods. So I didn't want to make the suggested code changes without test coverage.

We should ensure this library has adequate test coverage and make the suggested code changes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.