dotnet / dotnet/extensions

Microsoft.Extensions.Compliance.Redaction.NullRedactor doesn't seem to work

Open
#5,691 7 comments 0 reactions 1 assignee Claimed by @amadeuszl View on GitHub
area-compliance bug
Dominant language
C#
Stars
3.2k
Forks
894
Avg merge
1d 12h
Merged PRs (30d)
23

Description

### Description

Please see https://github.com/erwinkramer/bank-api/blob/main/BankApi.Service/Implementation/Model.AccessLog.cs

If i change `RestrictedData` to `UnrestrictedData`, i'm expecting the property to be visible in my logging, because in https://github.com/erwinkramer/bank-api/blob/main/BankApi.Service/Defaults/Builder.Compliance.cs i set `UnrestrictedData` with a `NullRedactor`.

### Reproduction Steps

1. Clone the repo: https://github.com/erwinkramer/bank-api/tree/main
2. Debug in Aspire mode
3. Run the test at this line: [http://{{host}}/{{apiVersion}}/teller](https://github.com/erwinkramer/bank-api/blob/cf21fba0b0bccf0518492ca99b150411641bab07/BankApi.Service/apptests.http#L15)

### Expected behavior

`NullRedactor` should just return the value as-is, as documented.

### Actual behavior

`NullRedactor` acts like the `ErasingRedactor`.

### Regression?

_No response_

### Known Workarounds

_No response_

### Configuration

Not sure if specific to a version

.NET SDK:
Version: 9.0.100
Commit: 59db016f11
Workload version: 9.0.100-manifests.3068a692
MSBuild version: 17.12.7+5b8665660

Runtime Environment:
OS Name: Windows
OS Version: 10.0.26100
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\9.0.100\

### Other information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.