dotnet / dotnet/extensions

Update Microsoft.Gen.Logging to Avoid LOGGEN036

Open
#5,672 5 comments 8 reactions 1 assignee Claimed by @dariusclay View on GitHub
area-telemetry bug
Dominant language
C#
Stars
3.2k
Forks
894
Avg merge
1d 12h
Merged PRs (30d)
23

Description

### Description

### Issue Description

The source generator from `Microsoft.Gen.Logging` should be compatible with `Microsoft.Extensions.Logging.Abstractions` and should not cause warnings or errors for users.

### Proposed Solution

Update the source generator in Microsoft.Gen.Logging to avoid triggering LOGGEN036 and similar warnings/errors and ensure compatibility with Microsoft.Extensions.Logging.Abstractions.

### Reproduction Steps

https://github.com/vanbukin/ReproExtensions5476/tree/main

### Expected behavior

The source generator from Microsoft.Gen.Logging should not trigger warnings or errors and should be compatible with Microsoft.Extensions.Logging.Abstractions.

### Actual behavior

Currently, it triggers warnings such as `LOGGEN036 : The type "" doesn't implement ToString(), IConvertible...`, which breaks builds when `treat warnings as errors` is enabled.

### Regression?

_No response_

### Known Workarounds

_No response_

### Configuration

_No response_

### Other information

Reference discussion in [issue #5476](https://github.com/dotnet/extensions/issues/5476#issuecomment-2478142288).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.