dotnet / dotnet/extensions-samples

Extensions samples should not set SuppressTfmSupportBuildWarnings

Open
#217 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
PowerShell
Stars
13
Forks
13
PR merge metrics
No merged PRs in 30d

Description

https://github.com/dotnet/extensions-samples/blob/c33a8bba6ac4ec61ad19bd4ab9dbd5b5838b6991/Directory.Build.props#L10

The `SuppressTfmSupportBuildWarnings` switch shouldn't be used in samples as it's a workaround to temporarily allow runtimes to consume a package that doesn't support that runtime anymore by falling back to the netstandard2.0 implementation. For System.* packages this switch might not work and we clearly document that this is an unsupported and untested scenario: https://github.com/dotnet/runtime/blob/28a069017673a03473fdd06e8d693a91e3eb9fbb/eng/packaging.targets#L222

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.