dotnet / dotnet/efcore

Problem with SQLitePCLExtensions.EncryptionSupported and GetNativeLibraryName

Open
#38,548 3 comments 0 reactions 0 assignees View on GitHub
area-adonet-sqlite needs-design
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

`SQLitePCLExtensions.EncryptionSupported` is using SQLitePCLRaw's `GetNativeLibraryName` to decide if the underlying SQLite library supports encryption or not. But the name of the library is not a reliable way to determine that. This is especially true with SQLitePCLRaw 3.x, where I am using the `e_sqlite3` base name for multiple implementations.

I'm not sure there currently is a way to implement `EncryptionSupported` which is compatible with all the various SQLite encryption libraries. Perhaps we could devise and implement one, but removal of `EncryptionSupported` should also be considered.

Contributor guide

Open the contributing guide

Research direction

Start at SQLitePCLExtensions.EncryptionSupported and trace its use of SQLitePCLRaw's GetNativeLibraryName. Review how SQLitePCLRaw 3.x names the e_sqlite3 implementations and determine whether a compatible detection approach is possible or removal is preferable. Done means resolving that design choice and implementing the agreed behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, sqlite
Domain
database
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.