dotnet / dotnet/efcore

Review SQLite pool implementation

Open
#37,921 0 comments 1 reaction 0 assignees View on GitHub
area-adonet-sqlite
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

Potential issues found by agent review:

|Finding|File|Issue|
|-|-|-|
|`SqliteConnectionPool` unbounded growth|`SqliteConnectionPool.cs:46`|No max pool size, no blocking wait|
|Nested lock in `SqliteConnectionPool.DisposeConnection`|`SqliteConnectionPool.cs:141`|Reentrant lock antipattern|
|`\_state` not volatile in `SqliteConnectionPoolGroup`|`SqliteConnectionPoolGroup.cs:9`|Stale read possible on ARM|
|Locking using `this`|`SqliteConnectionPoolGroup.cs:22,32,47,61`|It might be locked elsewhere, prefer Lock|

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.