dotnet / dotnet/efcore

SaveChangesAsync should create savepoints (and roll back to them) when under an ambient transaction

Open
#36,492 0 comments 0 reactions 0 assignees View on GitHub
area-save-changes
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

SaveChangesAsync currently manages transaction savepoints when it's executed within a user-managed transaction. However, it does not create a savepoint if an ambient System.Transactions transaction is in progress. We already have some detection and special handling of ambient transactions, it probably makes sense to have savepoints for this case as well.

Originally raised by @davidroth in #36470

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.