dotnet / dotnet/efcore

Split analyzers and code fix providers into different assemblies (but same package)

Open
#35,752 1 comment 2 reactions 0 assignees View on GitHub
area-analyzer
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

We have both code fixes in analyzers in the same assembly, which is something that shouldn't be done (see [RS1038](https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1038.md#other-extension-points)); our first code fix was added in #30835, and the reference to Microsoft.CodeAnalysis.Workspaces was added in that PR (/cc @DoctorKrolic).

In #34637 we upgraded to Microsoft.CodeAnalysis 4.13.0, at which point RS1038 started getting reported - it is currently suppressed.

We need to do some build work to have separate projects/assemblies for analyzers and code fixes, but pack them together into the same Microsoft.EntityFramework.Analyzers nuget pacakge. Note https://github.com/dotnet/runtime/issues/88701 which tracks the same for .NET interop analyzers/codefix.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.