dotnet / dotnet/efcore

Improve creation of RelationalCommandCache expression in RelationalShapedQueryCompilingExpressionVisitor

Open
#34,400 1 comment 0 reactions 0 assignees View on GitHub
area-precompiled-queries area-query
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

Create just empty `new HashSet(StringComparer.Ordinal)` and in 2nd step dynamically add the initializers as in `GenerateRelationalCommandCacheExpression`.

Original code:
```csharp
var commandLiftableConstant = RelationalDependencies.RelationalLiftableConstantFactory.CreateLiftableConstant(
relationalCommandCache,
c => new RelationalCommandCache(
c.Dependencies.MemoryCache,
c.RelationalDependencies.QuerySqlGeneratorFactory,
c.RelationalDependencies.RelationalParameterBasedSqlProcessorFactory,
queryExpression,
_useRelationalNulls,
),
"relationalCommandCache",
typeof(RelationalCommandCache));
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.