dotnet / dotnet/efcore

Query/Test: when verifying translation error, force using AssertTranslationFailedWithDetails, when details are provided

Open
#34,354 1 comment 1 reaction 0 assignees View on GitHub
area-query area-test
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

In our query tests we sometimes expect a translation to fail, and use AssertTranslationFailed method for that purpose. However, sometimes our pipeline provides additional details why the translation has failed and we should look at that also. We have AssertTranslationFailedWithDetails, but we should consider throwing when tests calls regular AssertTranslationFailed but there are details provided.

Need to see how noisy it's going to be, might be overkill, or we could just do a pass to fix some of the tests but don't force it on everyone.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.