dotnet / dotnet/efcore

AOT: properly deal with NetTopologySuite objects in the materializer for AOT scenarios

Open
#33,482 2 comments 0 reactions 0 assignees View on GitHub
area-aot area-query area-spatial consider-for-next-release
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

When producing a reader expression for NTS column, spatial type mappings use their own converters to modify the valueExpression in the `CustomizeDataReaderExpression` rather than going through normal converter process. Problem for AOT is that those converters capture SqlServerBytesReader object, which in turn uses NTS specific service (`NtsGeometryServices`) that we don't know about and can't effectively deal with using our liftable constant infra.

NTS is not supported in compiled model either so not huge priority, but we should deal with it in a proper way. For now just disable constant validation of that scenario by targeting a specific NTS type name, so not a very elegant solution.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.