dotnet / dotnet/efcore

Use testcontainer for SQL Server tests by default

Open
#33,267 6 comments 0 reactions 0 assignees View on GitHub
area-sqlserver area-test needs-design
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

Currently [SQL Server must be installed before running our tests](https://github.com/dotnet/efcore/blob/main/docs/getting-and-building-the-code.md). Historically. people typically got this by installing Visual Studio with LocalDb. However, this is no longer a great option because:

- The version of LocalDb that ships with Visual Studio is currently, and is usually, an older version.
- This doesn't help people on non-Windows machines
- Manual installation and configuration of dependencies is error prone, with better solutions now available.

We should therefore start using a SQL Server testcontainer by default. I understand that this will not work on the C.I., so we should ensure that the C.I. continues to work either in the old way, or in some other way that is supported by the C.I. system.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.