dotnet / dotnet/efcore

UpdateSqlGenerator.AppendUpdateColumnValue needs to throw for unimplemented JSON partial update

Open
#32,186 0 comments 0 reactions 1 assignee Claimed by @AndriySvyryd View on GitHub
area-json area-save-changes
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

Currently, a provider that wishes to support JSON partial update needs to override UpdateSqlGenerator.AppendUpdateColumnValue, checking columnModification.JsonPath and going into the special path. This should be a separate function that throws by default; a provider which doesn't override gets a totally mangled SQL.

/cc @maumar

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.