dotnet / dotnet/efcore

Query: revisit IsOrdinalKeyProperty

Open
#31,389 1 comment 0 reactions 0 assignees View on GitHub
area-json area-model-building area-query customer-reported
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

It currently tells us if the given key is ordinal property for this entity, however in case of JSON collection chain, each level adds one ordinal:

owner entity: 1 key property
owned collection root: 1 key property (from owner), 1 ordinal key
owned collection branch: 1 key property (from owner), 2 ordinal keys (one from it's parent and one it's own ordinal key)
owned collection branch: 1 key property from owner, 3 ordinals
and so on

IsOrdinalKeyProperty only detects entity's own key as being ordinal, ignoring the ones inherited from parent.
This is useful info when determining if a given key should be bound or ignored, but maybe we just need a different method for that purpose.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.