dotnet / dotnet/efcore

Json: move SqlServerValueGenerationConvention.GetValueGenerated(IConventionProperty property) JSON logic to relational

Open
#28,714 0 comments 0 reactions 1 assignee Claimed by @AndriySvyryd View on GitHub
area-conventions area-json
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

Currently we handle value generation in sql server. This is because in JSON case (if entity has been marked as json in the model configuration) we don't get to relational at all - property.GetMappedStoreObjects(StoreObjectType.Table) returns null because it relies on getting a column name for the property and for JSON that always goes back as null. Ideally we would refactor that code, so that correct table is returned and we get to relational so we can set value generated for JSON all in one place

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.