dotnet / dotnet/efcore

Query: Injecting into group by projection should check for distinct

Open
#28,071 0 comments 0 reactions 0 assignees View on GitHub
area-query area-test
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

https://github.com/dotnet/efcore/pull/27931 Added processing for lifting complex aggregate term to original group by query. See EnclosingTermFindingVisitor

Adding it should be safe in presence of GroupBy since that element could be key or aggregate only (else LINQ wouldn't compile)
But in front of Distinct it may not work. Though there is also another thing that if user doesn't condense grouping element then Distinct should/could fail. We just need to verify the scenario to make sure we are not adding terms into distinct projection.

Similar to #28039

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.