dotnet / dotnet/efcore

Make ModificationCommandComparer compare provider values

Open
#27,761 1 comment 2 reactions 0 assignees View on GitHub
area-save-changes
Dominant language
C#
Stars
14.8k
Forks
3.4k
PR merge metrics
PR metrics pending

Description

With table sharing where the PKs use value comparers with different ordering `ModificationCommandComparer` could order concurrent command batches in a way that could cause a deadlock.

Making this work for all cases requires the ProviderValueComparer to implement `IComparer`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.