dotnet / dotnet/eShop

Question: Unit price is not validated in `CreateOrderCommandHandler`

Open
#234 2 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
C#
Stars
10.9k
Forks
3.8k
Avg merge
1d 11h
Merged PRs (30d)
4

Description

Hi,

When I looked into the code how order is created, I spotted that unit price is passed from UI and not validated.

https://github.com/dotnet/eShop/blob/main/src/Ordering.API/Application/Commands/CreateOrderCommandHandler.cs

In real-world application this would mean I can buy something for minimum price.

Am I missing something?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.