RabbitMQ instrumentation
- Dominant language
- C#
- Stars
- 10.9k
- Forks
- 3.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 4
Description
There is some basic instrumentation of RabbitMQ messages. However, it is missing many of the standardized tags. And the kind is wrong in some places.
e.g. https://github.com/dotnet/eShop/blob/3b49f61a888656b038b5f044b0d4c5096fc9f073/src/EventBusRabbitMQ/RabbitMQEventBus.cs#L154 should be consumer instead of client. And I believe other client activities should be producer.
Conventions for spans:
* https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/
* https://opentelemetry.io/docs/specs/semconv/messaging/rabbitmq/
Options available are:
1. Improve eshop rabbitmq instrumentation.
2. Wait for built in OTEL support in the rabbitmq library with https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1261. Instrumentation added by eshop should be removed then.
Can do 1 and then remove with 2. Or wait for 2.
Contributor guide
Assessment
This issue has not been assessed yet.