dotnet / dotnet/dotnet-docker

Use manifest.json/image-info.json to determine which tests to run.

Open
#5,337 2 comments 0 reactions 0 assignees View on GitHub
area-infrastructure
Dominant language
Dockerfile
Stars
4.9k
Forks
2k
Avg merge
1d 14h
Merged PRs (30d)
26

Description

### Describe the Problem

Maintaining [TestData.cs](https://github.com/dotnet/dotnet-docker/blob/main/tests/Microsoft.DotNet.Docker.Tests/TestData.cs) causes merge conflicts during servicing and allows for human error. Most of this data is already duplicated in some way by the manifest.json file. We should consider using that file to drive our tests.

### Describe the Solution

[There is already a model for the manifest in the ImageBuilder tool](https://github.com/dotnet/docker-tools/tree/main/src/Microsoft.DotNet.ImageBuilder/src/Models/Manifest). We could either duplicate that model, create a simpler model in this repo just for reading the manifest, or factor out the model from ImageBuilder and publish it as a package.

Including a model to read the manifest file in this repo would also help with https://github.com/dotnet/dotnet-docker/issues/4704.

### Additional Context

- Should still allow for disabling specific image tests for certain cases.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.