Clean up duplicated .NET 8.0 Bookworm Dockerfile entries in manifest
- Dominant language
- Dockerfile
- Stars
- 4.9k
- Forks
- 2k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 26
Description
Now that https://github.com/dotnet/dotnet-docker/pull/4536 has been implemented, we no longer need to have duplicated Dockerfile entries between two different sets of shared tags, for the .NET 8.0 Bookworm Dockerfiles. Previous to https://github.com/dotnet/dotnet-docker/pull/4536, these needed to be duplicated so that, for example, the 8.0/bookworm-slim/amd64 can be associated with two different sets of shared tags:
* latest, 8.0-preview, 8.0.0-preview.1
* 8.0-preview-bookworm-slim, 8.0.0-preview.1-bookworm-slim
But now that Windows Dockerfiles are no longer included, these two sets of tags can be merged into one. This means the Bookworm Dockerfile entries don't need to be duplicated.
These changes don't apply to runtime-deps. Those entries are already implemented this way because Windows was never included there to begin with. Taking runtime as an example, what this means is that this whole section can be removed:
https://github.com/dotnet/dotnet-docker/blob/3bbd0b1b1f48f4c487a252a72fb894efd847549f/manifest.json#L1947-L1990
And its shared tags here:
https://github.com/dotnet/dotnet-docker/blob/3bbd0b1b1f48f4c487a252a72fb894efd847549f/manifest.json#L1951-L1952
Can be moved to be included here:
https://github.com/dotnet/dotnet-docker/blob/3bbd0b1b1f48f4c487a252a72fb894efd847549f/manifest.json#L1897-L1900
This would be applied for runtime, aspnet, and sdk.
Contributor guide
Assessment
This issue has not been assessed yet.