dotnet / dotnet/dotnet-docker

Not all sample images are built and tested in CI/PR validation

Open
#4,544 1 comment 1 reaction 0 assignees View on GitHub
area-test
Dominant language
Dockerfile
Stars
4.9k
Forks
2k
Avg merge
1d 14h
Merged PRs (30d)
26

Description

https://github.com/dotnet/dotnet-docker/pull/4534 restructured some of the sample dockerfiles, but left some of them, like [Dockerfile.debian](https://github.com/richlander/dotnet-docker/blob/654dbd52d157901292a22f20bf34006ff0a27bb6/samples/aspnetapp/Dockerfile.debian) unable to build and/or run.

The [dotnet-docker-samples](https://dev.azure.com/dnceng/internal/_build?definitionId=376) pipeline only ends up building images that we publish (defined in manifest.samples.json). There should be some additional PR validation that runs `pwsh .\build-and-test.ps1 -Path *samples* -TestCategories sample`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.