dotnet / dotnet/dotnet-api-docs

Documentation of System.Diagnostics.Switch should properly describe how to implement a derived class.

Open
#2,929 0 comments 0 reactions 0 assignees View on GitHub
area-System.Diagnostics Pri3 untriaged
Dominant language
C#
Stars
949
Forks
1.7k
Avg merge
3d 27m
Merged PRs (30d)
49

Description

All existing derived classes of `System.Diagnostics.Switch` save their state in `SwitchSetting` and override `OnValueChanged` to have `SwtichSetting` properly reflect the corresponding setting.

The documentation of `System.Diagnostics.Switch` however describes the process writing an inherited class as:
> When inheriting from this class, you must implement the `SwitchSetting` method

The problem here is that `SwitchSetting` isn't even `virtual`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.