dotnet / dotnet/dotnet-api-docs

Missing details

Open
#1,363 2 comments 0 reactions 0 assignees View on GitHub
area-System.Data dotnet-api/prod Pri2 untriaged
Dominant language
C#
Stars
949
Forks
1.7k
Avg merge
3d 27m
Merged PRs (30d)
49

Description

This documentation makes no mention of a type comparison between objects. The .net reference source indicates EquivalentTo will return false if `GetType() != connectionStringBuilder.GetType()`, i.e. the provided parameter is of a different type.

So, if I am comparing a SqlConnectionStringBuilder to a new DbConnectionStringBuilder object (created for the purposes of comparing the connection string), this method will return false even if an identical connection string was provided. This makes a big difference to the usefulness of the method and should certainly be documented.

---
#### Document Details

⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*

* ID: f1f8754a-a889-5af6-5d72-9adeffee60d2
* Version Independent ID: 5edb5da9-79ed-6b35-adf5-2338832d9e12
* Content: [DbConnectionStringBuilder.EquivalentTo(DbConnectionStringBuilder) Method (System.Data.Common)](https://docs.microsoft.com/en-us/dotnet/api/system.data.common.dbconnectionstringbuilder.equivalentto?view=netframework-4.7.2#System_Data_Common_DbConnectionStringBuilder_EquivalentTo_System_Data_Common_DbConnectionStringBuilder_)
* Content Source: [xml/System.Data.Common/DbConnectionStringBuilder.xml](https://github.com/dotnet/dotnet-api-docs/blob/master/xml/System.Data.Common/DbConnectionStringBuilder.xml)
* Product: **dotnet-api**
* GitHub Login: @douglaslMS
* Microsoft Alias: **douglasl**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.