dotnet / dotnet/docs

CA1515 breaking vs. non-breaking

Open
#43,159 0 comments 2 reactions 0 assignees View on GitHub
:watch: Not Triaged dotnet-fundamentals/svc
Dominant language
No language data
Stars
4.8k
Forks
6.1k
Avg merge
19h 10m
Merged PRs (30d)
268

Description

### Type of issue

Other (describe below)

### Description

The fix for "CA1515: Consider making public types internal" is documented as `non-breaking`. The rule states that "an application's API isn't _typically_ referenced publicly" (emphasis mine). However, _if_ those types are referenced, this is a breaking change. So, while the fix _typically_ isn't breaking, I __suggest to change the fix to be `breaking`__.

### Page URL

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1515

### Content source URL

https://github.com/dotnet/docs/blob/main/docs/fundamentals/code-analysis/quality-rules/ca1515.md

### Document Version Independent Id

af3fc3f7-ef43-5e8d-b30f-e1ec4d737811

### Article author

@CollinAlpert

### Metadata

* ID: b2d38cb7-a657-72d5-7d05-9d12e441b689
* Service: **dotnet-fundamentals**

[Related Issues](https://github.com/dotnet/docs/issues?q=is%3Aissue+is%3Aopen+af3fc3f7-ef43-5e8d-b30f-e1ec4d737811)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.