dotnet / dotnet/docs

Bad await FromResult examples

Open
#43,094 1 comment 0 reactions 0 assignees View on GitHub
async-task-programming/subsvc dotnet-csharp/svc
Dominant language
No language data
Stars
4.8k
Forks
6.1k
Avg merge
19h 10m
Merged PRs (30d)
268

Description

### Type of issue

Missing information

### Description

There are 2 places in the page where it does `return await Task.FromResult(new User() { id = userId });` await and Task.FromResult are the opposite, the should not be use together.

Also, there are no example on what to do if the method is synchronous but must return a Task, ex: when implementing an interface.

### Page URL

https://learn.microsoft.com/en-us/dotnet/csharp/asynchronous-programming/async-scenarios

### Content source URL

https://github.com/dotnet/docs/blob/main/docs/csharp/asynchronous-programming/async-scenarios.md

### Document Version Independent Id

77bdee53-c2a0-e16f-c93a-3ca0afae0b93

### Article author

@BillWagner

### Metadata

* ID: d885f1eb-2b37-693b-c91f-74b748c9424a
* Service: **dotnet-csharp**
* Sub-service: **async-task-programming**

[Related Issues](https://github.com/dotnet/docs/issues?q=is%3Aissue+is%3Aopen+77bdee53-c2a0-e16f-c93a-3ca0afae0b93)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.