dotnet / dotnet/docs

AddAspNetCoreInstrumentation() in metrics setup is duplicative

Open
#36,875 0 comments 0 reactions 1 assignee Claimed by @samsp-msft View on GitHub
:watch: Not Triaged dotnet-fundamentals/svc
Dominant language
No language data
Stars
4.8k
Forks
6.1k
Avg merge
19h 10m
Merged PRs (30d)
268

Description

Hey @samsp-msft, I just noticed we have both AddAspNetCoreInstrumentation() and AddMeter("Microsoft.AspNetCore.Hosting"). I don't think we need AddAspNetCoreInstrumentation() any longer, it only has one http.server.duration metric on it which is already covered by the Hosting Meter.

---
#### Document Details

⚠ *Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.*

* ID: d6316286-f76d-24c0-831a-aabb4796e1f8
* Version Independent ID: 9db87c45-60ba-ce17-118c-f9bd15306ece
* Content: [.NET Observability with OpenTelemetry](https://learn.microsoft.com/en-us/dotnet/core/diagnostics/observability-with-otel#5-configure-opentelemetry-with-the-correct-providers)
* Content Source: [docs/core/diagnostics/observability-with-otel.md](https://github.com/dotnet/docs/blob/main/docs/core/diagnostics/observability-with-otel.md)
* Product: **dotnet-fundamentals**
* GitHub Login: @tommcdon
* Microsoft Alias: **tommcdon**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.