Missing Breaking Change: AppleAuthenticationOption property PrivateKey behaves differently
- Dominant language
- No language data
- Stars
- 4.8k
- Forks
- 6.1k
- Avg merge
- 19h 10m
- Merged PRs (30d)
- 268
Description
The breaking change on this setting breaks AppleId OAuth when moving to .NET6.
The breaking change is briefly discussed here: https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/issues/385#issuecomment-1056507578
When moving to .NET 6 and using the AppleAuthenticationOption.PrivateKey property, the content is no longer loaded as a byte array (so using Convert.FromBase64String is not needed anymore), this change is very obvious. However, the changes to AspNet.Security.OAuth.Apple.Internal.DefaultClientSecretGenerator are well hidden, the value returned by the Function assigned to AppleAuthenticationOption.PrivateKey must not strip the "-----BEGIN PRIVATE KEY-----" and "-----END PRIVATE KEY-----" lines anymore.
---
#### Document Details
⚠ *Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.*
* ID: a07a4a03-5b9a-0360-7c78-14284b1cb029
* Version Independent ID: 0ea0a42e-2169-349b-e2e8-fb01ff4874ba
* Content: [Breaking changes in .NET 6 - .NET](https://learn.microsoft.com/en-us/dotnet/core/compatibility/6.0)
* Content Source: [docs/core/compatibility/6.0.md](https://github.com/dotnet/docs/blob/main/docs/core/compatibility/6.0.md)
* Product: **dotnet-fundamentals**
* GitHub Login: @gewarren
* Microsoft Alias: **gewarren**
Contributor guide
Assessment
This issue has not been assessed yet.