dotnet / dotnet/docs

Repositories shouldn't be mandatory section is not helpful

Open
#26,016 0 comments 1 reaction 0 assignees View on GitHub
dotnet-architecture/svc microservices/subsvc
Dominant language
No language data
Stars
4.8k
Forks
6.1k
Avg merge
19h 10m
Merged PRs (30d)
268

Description

Hi there,

I have been loving the Microsoft documentation on design patterns and especially this one for database persistence. However the section about repositories not being mandatory is very short and the quote to me is coming from someone who has some other advanced patterns in his systems that mean he doesn't need repository. That is fine for him, but i don't think that quote is actually useful and only serves to contradict what the rest of the document says without providing actionable alternatives.

If you could ask him to expand on the quote

> I can use the full power of the persistence layer, and push all that domain behaviour into my aggregate roots

This doesn't provide the reader anything to do except to feel as though they might be wrong about repositories in their project and leave them with no solution to the problems that arise from directly using your ORM in your commands.

The section could be paraphrased as the following I think:

> Although the whole rest of the document makes a clear and good case for infrastructure isolation and using repository pattern to achieve it some people don't think it's required and offered us feedback to say that but haven't provided us with sufficient detail on how they solve the same problems that persistence layer isolation aims to address.

Which isn't very helpful.

Thanks and again this doc is great, but that section seems like a very shallow afterthought that doesn't add anything actionable for the reader to do if they want to not make repositories mandatory.

---
#### Document Details

⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*

* ID: c3000b84-336c-df28-05d2-de8b9d9708ee
* Version Independent ID: 5d327117-1420-8110-963b-822b6acdc976
* Content: [Designing the infrastructure persistence layer](https://docs.microsoft.com/en-us/dotnet/architecture/microservices/microservice-ddd-cqrs-patterns/infrastructure-persistence-layer-design)
* Content Source: [docs/architecture/microservices/microservice-ddd-cqrs-patterns/infrastructure-persistence-layer-design.md](https://github.com/dotnet/docs/blob/main/docs/architecture/microservices/microservice-ddd-cqrs-patterns/infrastructure-persistence-layer-design.md)
* Product: **dotnet-architecture**
* Technology: **microservices**
* GitHub Login: @nishanil
* Microsoft Alias: **nanil**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.