dotnet / dotnet/docs-tools

[CleanRepo] Orphaned images being mistakenly removed

Open
#445 0 comments 0 reactions 1 assignee Claimed by @gewarren View on GitHub
bug
Dominant language
C#
Stars
27
Forks
43
Avg merge
13h 27m
Merged PRs (30d)
21

Description

While using cleanrepo to remove orphaned images on xamarin-docs-pr I discovered the following markdown formats weren't being handled by the tool, and so images were being removed that shouldn't have been:

```
![The Widget tab for an activity
indicator](progress-indicators-images/activity02.png "The Widget tab for
an activity indicator")

A high resolution version of the class diagram can be downloaded from [here](class-hierarchy-images/class-diagram-high-resolution.png).
```

I particularly like the multiple cases of spreading an image link over three lines! Not sure if it's worth the tool handling this. I just fixed the markdown instead. But there were quite a few examples of the second case where an image is actually a download link. In those cases I dropped the images back in place after they were removed. There was also a third case due to writer error on lightbox images (where the images actually rendered fine on learn, despite the markdown being incorrect) - I fixed those.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.