dotnet / dotnet/docker-tools

Use PR to submit readme/tag changes to mcrdocs repo

Open
#529 0 comments 0 reactions 0 assignees View on GitHub
area-infrastructure enhancement
Dominant language
C#
Stars
181
Forks
67
Avg merge
2d 15h
Merged PRs (30d)
10

Description

Currently Image Builder updates readmes and tag YAML files in the mcrdocs repo with a direct commit. There was recently a case where such a commit introduce duplicate tag references that results in a PR validation error. But the commit that made the change bypassed any kind of validation. This resulted in other people getting validation errors for their PRs in that repo.

One way to prevent this from happening is for Image Builder to no longer directly commit changes to the repo and instead submit a PR that undergoes validation. If the validation succeeds, then the PR can be automatically merged. One challenge with this approach is needing to avoid cases where a validation error unrelated to our changes prevents the PR validation from succeeding. We would not want that to fail our build.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.