dotnet / dotnet/docker-tools

"AutoBuilder - Failed" issues should be left open

Open
#2,085 0 comments 1 reaction 2 assignees Claimed by @lbussell View on GitHub
area-infrastructure
Dominant language
C#
Stars
181
Forks
67
Avg merge
2d 15h
Merged PRs (30d)
10

Description

Currently, `NotificationService` immediately closes any issue that does not have the `failure` label:

https://github.com/dotnet/docker-tools/blob/78513bb41bc2a907b161c6e13cd0699b5252c5d9/src/ImageBuilder/NotificationService.cs#L84-L93

The `failure` label is only added when an exception is thrown, not when the category is "Failed" due to recent build failures:

https://github.com/dotnet/docker-tools/blob/6b2d022bdc30337399970a962c2c933ee95d2c8c/src/ImageBuilder/Commands/QueueBuildCommand.cs#L191-L206

https://github.com/dotnet/docker-tools/blob/6b2d022bdc30337399970a962c2c933ee95d2c8c/src/ImageBuilder/Commands/QueueBuildCommand.cs#L269-L273

This means "AutoBuilder - Failed" issues are filed and immediately closed. These issues are actionable and should be left open so that they are visible and can be triaged.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.