dotnet / dotnet/docker-tools

There needs to be two different types of "dry-run" in ImageBuilder

Open
#2,070 0 comments 0 reactions 0 assignees View on GitHub
area-infrastructure up-for-grabs
Dominant language
C#
Stars
181
Forks
67
Avg merge
2d 15h
Merged PRs (30d)
10

Description

The `--dry-run` global CLI option is inconsistent. There are two use cases I'm thinking about:
1. As a container image maintainer, I want to be able to run things like the ACR cleanup pipeline in dry-run mode, against production data, *with full authentication* -- so that I can be sure what action will be taken before anything is deleted. This is "no side effects mode".
2. As the maintainer of ImageBuilder, I want to have some commands run in public PR validation *without authentication* to make sure that a pull request hasn't broken our pipelines. This is "no permissions mode"

Both are valid but distinct scenarios. Having both contained under the `--dry-run` flag is inconsistent.

I propose that `--dry-run` should just be #1 or we should change this functionality to be enum-based.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.