dotnet / dotnet/docker-tools

Use pipeline variable to reference MAR Status API resource/scope

Open
#1,288 3 comments 0 reactions 1 assignee Claimed by @lbussell View on GitHub
area-infrastructure up-for-grabs wave1
Dominant language
C#
Stars
181
Forks
67
Avg merge
2d 15h
Merged PRs (30d)
10

Description

Currently we hardcode the resource scope for the MAR status API: https://github.com/dotnet/docker-tools/blob/7b8f03267f6687fd6ecf7bca1071f74536c1cfa6/src/Microsoft.DotNet.ImageBuilder/src/McrStatusClient.cs#L20

This is very inflexible and requires changes to our source code if we need to change where this points to. Instead, we should accept a scope via the CLI and pass it in via an environment variable so that we can change it as needed without rebuilding ImageBuilder. We don't intend to frequently access this API on dev machines, so this should be an acceptable solution.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.