dotnet / dotnet/docker-tools

Allow test-dependencies between arch/platform in GenerateBuildMatrix command

Open
#1,177 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
181
Forks
67
Avg merge
2d 15h
Merged PRs (30d)
10

Description

https://github.com/dotnet/dotnet-docker/blob/f270639b443e85fe6db63fe598a4ab1eec24ff33/manifest.json#L948-L957

Currently, we offer arm32v7 native AOT images for runtime-deps but not for sdk. This means that we need to use the arm64 AOT SDK to test the arm32 AOT deps image.

When generating the PlatformVersionedOs build matrix (for tests), ImageBuilder currently groups legs by architecture/platform before integral test dependencies. We want to build and test arm32 AOT images in the same leg as arm64 AOT SDK images for the PlatformVersionedOS build matrix type. The GenerateBuildMatrix command needs changes to allow custom build leg dependencies to transcend architecture like that.

The code in question is here:
https://github.com/dotnet/docker-tools/blob/0ccb9b854f816b67aae99bae0acb4775ef019a47/src/Microsoft.DotNet.ImageBuilder/src/Commands/GenerateBuildMatrixCommand.cs#L267-L276

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.