dotnet / dotnet/diagnostics

Add more profiles for dotnet trace with known .NET events

Open
#3,026 6 comments 6 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
1.3k
Forks
404
Avg merge
2d 3h
Merged PRs (30d)
38

Description

## Background and Motivation

We should expand the list of known profiles to include networking and ASP.NET Core events.

## Proposed Feature

https://github.com/dotnet/diagnostics/blob/c13a550fd8135e031678015743557ea2a543403f/src/Tools/dotnet-trace/CommandLine/Commands/ListProfilesCommandHandler.cs#L43

We should have networking and ASP.NET Core. I'm thinking that aspnetcore would encapsulate:
- Microsoft-AspNetCore-Server-Kestrel
- Microsoft.AspNetCore.Hosting

Networking
- System.Net.Http
- System.Net.NameResolution
- System.Net.Sockets
- System.Net.Security

We need to figure out what level we should use and if we need a verbose option as well.

YARP has a helper library that grabs ASP.NET Core and networking events, we'd want to use the same list here:

https://github.com/microsoft/reverse-proxy/tree/main/src/TelemetryConsumption

cc @MihaZupan

## Usage Examples

```
dotnet trace collect --profile aspnet
dotnet trace collect --profile networking
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.